Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: add go 1.22.8 entry for 3.4 and 3.5 #18743

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Oct 15, 2024

Add an entry regarding using Go 1.22.8 for releases 3.4 and 3.5.

Part of: #18665

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ivanvc ivanvc mentioned this pull request Oct 15, 2024
9 tasks
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (54db7f0) to head (e6c7449).

Current head e6c7449 differs from pull request most recent head 482eac3

Please upload reports for the commit 482eac3 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18743      +/-   ##
==========================================
- Coverage   68.79%   68.74%   -0.06%     
==========================================
  Files         420      420              
  Lines       35493    35493              
==========================================
- Hits        24419    24400      -19     
- Misses       9648     9656       +8     
- Partials     1426     1437      +11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54db7f0...482eac3. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 264d329 into etcd-io:main Oct 16, 2024
33 checks passed
@ivanvc ivanvc deleted the update-changelog-with-go-1.22.8-update branch October 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants