Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate currency information in locale #2476

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

atjn
Copy link
Contributor

@atjn atjn commented Mar 20, 2024

Closes espruino/BangleApps#3269
Analogous to espruino/BangleApps#3278

I am sorry but it is quite overwhelming to try and figure out how I can test this. Could you maybe point me to some docs on how to quickly build an emulator for the runtime? Then I will happily test it :)

@atjn
Copy link
Contributor Author

atjn commented Mar 20, 2024

BTW is it on purpose that the number implementation is different between this package and the one in the app loader? It seems like a pretty big problem to me.

@gfwilliams
Copy link
Member

Do you actually have a Bangle.js device? Because if so, you can just go to the GitHub actions tab, download the built firmware and flash it.

I'm not super happy with adding getters/setters in here though - it's just complicating things instead of simplifying (which I guess was the idea of deprecating currency?). Maybe just have the single change to currency?

@atjn
Copy link
Contributor Author

atjn commented Mar 20, 2024

Do you actually have a Bangle.js device? Because if so, you can just go to the GitHub actions tab, download the built firmware and flash it.

Yes thanks I'll try that

@atjn atjn force-pushed the deprecate-currency branch from 9345064 to e5fbdaa Compare March 20, 2024 12:55
@gfwilliams
Copy link
Member

Thanks - I'll get this in.

As for the number thing - yes, that's a good point. Just one of those things where someone updated the app but didn't think to push it to Bangle.js. I'll update that now as well.

@gfwilliams gfwilliams merged commit e5fbdaa into espruino:master Mar 22, 2024
15 checks passed
@atjn atjn deleted the deprecate-currency branch March 23, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate currency information in locale
2 participants