Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 build docs #2441

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Python3 build docs #2441

merged 3 commits into from
Dec 14, 2023

Conversation

brendena
Copy link
Contributor

Made the build_doc script work with python3. Mostly just migrating the libraries to newer version.

Library change
I needed to switch out mdx_urlize for markdown2 because this extension doesn't support the latest markdown python library. It seems that it will never. Somebody did a pull request in 2022 with the fix for it and it still hasn't been accepted. r0wb0t/markdown-urlize#17

Affected libraries. EspruinoDocs will need to be told to use python not python2.7
https://github.com/espruino/EspruinoDocs/blob/master/build.sh#L31

@gfwilliams
Copy link
Member

Hi - I'm not sure if it was a typo but you'd removed importlib from common.py and while docs would have built, that stopped any of the code building. I've just re-added it and everything seems to work again but let me know if there was some reason

@gfwilliams gfwilliams merged commit 7eff459 into espruino:master Dec 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants