Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on nuttx getting started article #364

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion content/blog/nuttx-getting-started/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,10 @@ git clone https://github.com/apache/nuttx-apps apps

### Building an App to Connect to a Wi-Fi network

NuttX provides ready-to-use board default configurations that enable the required config (from Kconfig) for a use scenario, such as Wi-Fi or I2C. You can list all available configurations for the ESP32 DevKitC V4 board using the following command, inside the NuttX directory:
NuttX provides ready-to-use board default configurations that enable the required config (from Kconfig) for a use scenario, such as Wi-Fi or I2C. To enter NuttX directory and list all available configurations for the ESP32 DevKitC V4 board you can use the following command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comma. It helps to visually separate the first part of the sentence saying what will happen from the second part of the sentence saying what you need to do to make it happen.

Suggested change
NuttX provides ready-to-use board default configurations that enable the required config (from Kconfig) for a use scenario, such as Wi-Fi or I2C. To enter NuttX directory and list all available configurations for the ESP32 DevKitC V4 board you can use the following command:
NuttX provides ready-to-use board default configurations that enable the required config (from Kconfig) for a use scenario, such as Wi-Fi or I2C. To enter NuttX directory and list all available configurations for the ESP32 DevKitC V4 board, you can use the following command:

If I may, I would like to propose further improvements to the sentence. The command cd is self-evident to most people, so the part To enter NuttX directory sounds like partonizing. How about this:

To list all available configurations for the ESP32 DevKitC V4 board, go to your nuttx directory and run:

Copy link
Contributor Author

@eren-terzioglu eren-terzioglu Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this:

"To list all available configurations for the ESP32 DevKitC V4 board, go to your nuttxspace directory and run:"

Directory structure looks like this:

.
└── nuttxspace/
    ├── nuttx
    └── apps

If we say go to your nuttx directory, we don't need to add cd nuttx command, I think. Adding cd nuttx command is the main purpose of this PR.


```bash
cd nuttx
./tools/configure.sh -L | grep esp32-devkitc
```

Expand Down
Loading