Fix/repair dropdown menu button #362
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr362/ |
pedrominatel
approved these changes
Dec 16, 2024
|
@pedrominatel Thanks! |
|
@brianignacio5 PTAL |
|
@georgik Feel free to review or share your feedback. |
@brianignacio5 Thank you for your help investigating this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the burger menu button for mobile devices, as it did not react to click events.
I tried reverting the changes to the point in time where the button worked to find out what introduced the wrong behavior. Unfortunately, it didn't help.
Most likely, the issue appeared due to our customizations to the theme. We fast forwarded the Blowfish theme (submodule) to upstream at some point, but the changes in the theme files that we store in
./layoutswere not synced to their./themes/blowfish/layouts/counterparts. Updates to the theme files were done according to the Hugo guide Customize a Theme.Related
Testing
Tested the interaction with the burger menu button in the following environments:
Checklist
Before submitting a Pull Request, please ensure the following: