Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add separate workflows to build and deploy preview pr #359

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

f-hollow
Copy link
Collaborator

@f-hollow f-hollow commented Dec 10, 2024

Description

Following #348 , this PR splits pr-deploy-preview into pr-build-preview and pr-deploy-preview to adjust access permissions so that fork PRs can be deployed for preview safely.

Resources:

Related

Testing

  • Testing to be done

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@f-hollow f-hollow force-pushed the feat/adjust_access_for_preview_prs branch 2 times, most recently from d038695 to f2b245c Compare December 10, 2024 08:39
@f-hollow f-hollow force-pushed the feat/adjust_access_for_preview_prs branch from f2b245c to a9187db Compare December 10, 2024 09:02
@f-hollow
Copy link
Collaborator Author

@pedrominatel Thanks!

@f-hollow f-hollow merged commit f853ed1 into main Dec 10, 2024
4 checks passed
@f-hollow f-hollow deleted the feat/adjust_access_for_preview_prs branch December 10, 2024 09:05
@f-hollow f-hollow mentioned this pull request Dec 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants