-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info on mac installation #4621
Conversation
Brew just happily installed Version: 2024.12.4 for me
WalkthroughThe pull request updates the ESPHome installation guide for macOS in the Changes
Possibly related PRs
Suggested reviewers
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
guides/installing_esphome.rst (2)
59-60
: Improve clarity of alternative installation instructions.The alternative installation method combines too many concepts in a single sentence. Consider breaking it down and adding the specific Python version requirement.
Apply this change:
-Alternatively, you can follow process similar to installing in Linux. You can install Python from the -official site or brew, have in mind that you may have an outdated Python version installed already, and then install ESPHome with ``pip3 install esphome``. You can +Alternatively, you can follow a process similar to the Linux installation: + +1. Install Python 3.9 or newer from the `official site <https://www.python.org/downloads/>`_ or Homebrew + (Note: macOS may come with an outdated Python version) +2. Install ESPHome with ``pip3 install esphome`` + +You can
52-60
: Update ESPHome version number in examples.The version numbers shown in the verification commands (2021.12.3) are outdated. According to the PR description, you're using version 2024.12.4. Consider updating all version numbers in the examples to reflect a current version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
guides/installing_esphome.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
guides/installing_esphome.rst (1)
Pattern **
: - Do not generate or add any sequence diagrams
🔇 Additional comments (1)
guides/installing_esphome.rst (1)
55-57
: LGTM! Clear and consistent command block.The Homebrew installation command is well-formatted and follows the document's style conventions.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
same thing has been just merged ¯_(ツ)_/¯ |
Brew just happily installed Version: 2024.12.4 for me
Description:
Just an update on installation, no other changes needed
Checklist:
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook - just updated existing rst