Skip to content

fix: prefix PrivateIdentifier names with a # #4526

fix: prefix PrivateIdentifier names with a #

fix: prefix PrivateIdentifier names with a # #4526

Triggered via pull request January 14, 2025 03:24
Status Failure
Total duration 1m 17s
Artifacts

test-js.yml

on: pull_request
Matrix: test_js
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 3 warnings
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > reports functions that can "safely" be changed: tests/rules/prefer-tacit.test.ts#L25
Error: Snapshot `prefer-tacit > typescript > reports functions that can "safely" be changed 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "ArrowFunctionExpression", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 29, 38, ], "text": "f", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:25:39
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > reports functions that are just instantiations: tests/rules/prefer-tacit.test.ts#L44
Error: Snapshot `prefer-tacit > typescript > reports functions that are just instantiations 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "FunctionDeclaration", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 26, 66, ], "text": "const foo = f<number>;", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:44:38
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > options > checkMemberExpressions > report member expressions when enabled: tests/rules/prefer-tacit.test.ts#L128
Error: Snapshot `prefer-tacit > typescript > options > checkMemberExpressions > report member expressions when enabled 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "FunctionDeclaration", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 46, 80, ], "text": "const foo = a.b.bind(a);", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:128:43
Test - Node: 18.18 - TS: latest - OS: ubuntu-latest
Process completed with exit code 1.
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > reports functions that can "safely" be changed: tests/rules/prefer-tacit.test.ts#L25
Error: Snapshot `prefer-tacit > typescript > reports functions that can "safely" be changed 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "ArrowFunctionExpression", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 29, 38, ], "text": "f", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:25:39
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > reports functions that are just instantiations: tests/rules/prefer-tacit.test.ts#L44
Error: Snapshot `prefer-tacit > typescript > reports functions that are just instantiations 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "FunctionDeclaration", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 26, 66, ], "text": "const foo = f<number>;", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:44:38
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > options > checkMemberExpressions > report member expressions when enabled: tests/rules/prefer-tacit.test.ts#L128
Error: Snapshot `prefer-tacit > typescript > options > checkMemberExpressions > report member expressions when enabled 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "FunctionDeclaration", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 46, 80, ], "text": "const foo = a.b.bind(a);", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:128:43
Test - Node: 20 - TS: latest - OS: ubuntu-latest
Process completed with exit code 1.
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > reports functions that can "safely" be changed: tests/rules/prefer-tacit.test.ts#L25
Error: Snapshot `prefer-tacit > typescript > reports functions that can "safely" be changed 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "ArrowFunctionExpression", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 29, 38, ], "text": "f", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:25:39
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > reports functions that are just instantiations: tests/rules/prefer-tacit.test.ts#L44
Error: Snapshot `prefer-tacit > typescript > reports functions that are just instantiations 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "FunctionDeclaration", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 26, 66, ], "text": "const foo = f<number>;", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:44:38
tests/rules/prefer-tacit.test.ts > prefer-tacit > typescript > options > checkMemberExpressions > report member expressions when enabled: tests/rules/prefer-tacit.test.ts#L128
Error: Snapshot `prefer-tacit > typescript > options > checkMemberExpressions > report member expressions when enabled 1` mismatched - Expected + Received @@ -9,18 +9,18 @@ "nodeType": "FunctionDeclaration", "ruleId": "prefer-tacit", "severity": 2, "suggestions": [ { - "desc": "Potentially unnecessary function wrapper.", + "desc": "Remove unnecessary function wrapper.", "fix": { "range": [ 46, 80, ], "text": "const foo = a.b.bind(a);", }, - "messageId": "generic", + "messageId": "genericSuggestion", }, ], }, ] ❯ tests/rules/prefer-tacit.test.ts:128:43
Test - Node: latest - TS: latest - OS: ubuntu-latest
Process completed with exit code 1.
Test - Node: 18.18 - TS: latest - OS: ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Test - Node: 20 - TS: latest - OS: ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Test - Node: latest - TS: latest - OS: ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636