Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/edit metadata #176

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Feat/edit metadata #176

merged 8 commits into from
Dec 7, 2023

Conversation

mheggelund
Copy link
Collaborator

@mheggelund mheggelund commented Nov 30, 2023 •
edited
Loading

closes #146

@mheggelund mheggelund requested a review from Sinrefvol November 30, 2023 12:29
Sinrefvol
Sinrefvol requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Sinrefvol Sinrefvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you go through places where you ignore exhaustive-deps error and check whenever it is a right choice to ignore it.
Refer to this article

src/features/AddModel/AddModelDialog/AddModelDialog.tsx Show resolved Hide resolved
src/features/AddModel/ModelMetadata/ModelMetadata.tsx Outdated Show resolved Hide resolved
@mheggelund mheggelund requested a review from Sinrefvol December 7, 2023 08:03
@mheggelund mheggelund merged commit b0f6e8b into main Dec 7, 2023
@mheggelund mheggelund deleted the feat/edit-metadata branch December 7, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sinrefvol Sinrefvol Sinrefvol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit metadata for a model
2 participants
@mheggelund @Sinrefvol