Update remaining steps upon task completion

equinor · Apr 18, 2024 · f3dd2a8 · f3dd2a8
1 parent a74ce92
commit f3dd2a8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/isar/state_machine/state_machine.py b/src/isar/state_machine/state_machine.py
@@ -396,6 +396,16 @@ def update_current_step(self):
         if self.current_task:
             self.current_step = self.current_task.next_step()
 
+    def update_remaining_steps(self):
+        if self.current_task:
+            for step in self.current_task.steps:
+                if (
+                    step.status == StepStatus.InProgress
+                    or step.status == StepStatus.NotStarted
+                ):
+                    step.status = self.current_task.status
+                    self.publish_step_status(step=step)
+
     def update_state(self):
         """Updates the current state of the state machine."""
         self.current_state = States(self.state)

diff --git a/src/isar/state_machine/states/monitor.py b/src/isar/state_machine/states/monitor.py
@@ -132,6 +132,7 @@ def _run(self) -> None:
                         self.state_machine.current_task
                     )
                     if self.state_machine.current_task.status == TaskStatus.Successful:
+                        self.state_machine.update_remaining_steps()
                         try:
                             self.state_machine.current_task = (
                                 self.state_machine.task_selector.next_task()

diff --git a/tests/isar/state_machine/states/test_monitor.py b/tests/isar/state_machine/states/test_monitor.py
@@ -40,7 +40,9 @@ def test_should_only_upload_if_status_is_completed(
     step.status = StepStatus.Successful if is_status_successful else StepStatus.Failed
     task: Task = Task(steps=[step])
     mission: Mission = Mission(tasks=[task])
-    mission.status = MissionStatus.Successful if is_status_successful else MissionStatus.Failed
+    mission.status = (
+        MissionStatus.Successful if is_status_successful else MissionStatus.Failed
+    )
 
     monitor.state_machine.current_mission = mission
     monitor.state_machine.current_task = task