Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Area #2015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Area #2015

wants to merge 1 commit into from

Conversation

Christdej
Copy link
Contributor

@Christdej Christdej commented Feb 10, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Christdej Christdej added backend Backend related functionality breaking-change A breaking change which introduces changes to the public APIs frontend Frontend related functionality labels Feb 10, 2025
@Christdej Christdej self-assigned this Feb 10, 2025
@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Christdej
Copy link
Contributor Author

Will now give warnings on Return to Home missions if they fail becuase we dont have an Area, awaiting Return Home functionallity to be removed aswell.

@Christdej Christdej force-pushed the removearea branch 2 times, most recently from 0552a91 to 1e99cac Compare February 10, 2025 13:29
andchiind
andchiind reviewed Feb 11, 2025
View reviewed changes
backend/api/Controllers/MissionSchedulingController.cs
@@ -397,7 +339,6 @@ [.. missionInspectionAreaNames]
Name = missionDefinition.Name,
InspectionFrequency = scheduledMissionQuery.InspectionFrequency,
InstallationCode = scheduledMissionQuery.InstallationCode,
InspectionArea = area.InspectionArea,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause the created MissionRun to always have no inspection area?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It either uses a existing missionDefinition or creates a new mission definition here. Since this is the only way new mission definitions are created, and since we don't give the mission definition an inspection area, none of the mission definitions and mission runs will have inspection areas. And since the robots get inspection areas from the first mission they run, they also won't have inspection areas.

backend/api/Controllers/MissionSchedulingController.cs
Comment on lines -439 to -445
if (
missionRun.Robot.CurrentInspectionArea != null
&& !await localizationService.RobotIsOnSameInspectionAreaAsMission(
missionRun.Robot.Id,
missionRun.InspectionArea!.Id
)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should ideally be in a separate commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Christdej Christdej

Labels
backend Backend related functionality breaking-change A breaking change which introduces changes to the public APIs frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christdej @andchiind