Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify getAccessible functions #2013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Christdej
Copy link
Contributor

@Christdej Christdej commented Feb 7, 2025

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Christdej Christdej added the backend Backend related functionality label Feb 7, 2025
@Christdej Christdej self-assigned this Feb 7, 2025
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might this PR make the code slightly less safe, since if someone now accidentally calls GetAreas for instance, they might not be aware that they are sharing information the user should not have access to?

@Christdej
Copy link
Contributor Author

Might this PR make the code slightly less safe, since if someone now accidentally calls GetAreas for instance, they might not be aware that they are sharing information the user should not have access to?

Potientially, but I think that we should not base the safety of the system om people remembering to use the correct function or add the correct .Where from a database call. So we should perhaps look into how we can fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants