Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple tests for RobotModelController #2009

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add simple tests for RobotModelController #2009

wants to merge 2 commits into from

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Feb 5, 2025

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@aeshub aeshub added the improvement Improvement to existing functionality label Feb 5, 2025
@aeshub aeshub self-assigned this Feb 5, 2025
andchiind
andchiind reviewed Feb 11, 2025
View reviewed changes
backend/api.test/Controllers/RobotModelControllerTests.cs

// Seven models are added by default to the database
// This number must be changed if new robots are introduced
Assert.Equal(7, robotModels!.Count);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it maybe be good to have a clean database for the tests in this file and then add the models here using DatabaseUtilities? It's not too clear where these 7 are added at the momnt. I'm OK with the tests as is, this is just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@aeshub aeshub

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeshub @andchiind