Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IDA MQTT message to update inspection view #1968

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Use IDA MQTT message to update inspection view #1968

merged 1 commit into from
Jan 30, 2025
+188 −33

Conversation

mrica-equinor
Copy link
Contributor

@mrica-equinor mrica-equinor commented Jan 17, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@mrica-equinor mrica-equinor self-assigned this Jan 17, 2025
@mrica-equinor mrica-equinor added backend Backend related functionality improvement Improvement to existing functionality frontend Frontend related functionality labels Jan 17, 2025
Christdej
Christdej approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor force-pushed the ida-mqtt-broker branch 3 times, most recently from abd58b5 to b0a0159 Compare January 30, 2025 11:29
Christdej
Christdej approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor merged commit 0f02d15 into equinor:main Jan 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

@mrica-equinor mrica-equinor

Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrica-equinor @Christdej