Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let sandpaper translate section headings #16

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Apr 5, 2024

With this change, sandpaper can now only do its magic and translate the strings instead of relying on hardcoded section title added in the lesson source

image

I'll let you do the change in the other repos.

@Bisaloo Bisaloo requested a review from avallecam April 5, 2024 09:08
Copy link

github-actions bot commented Apr 5, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-late/compare/md-outputs..md-outputs-PR-16

The following changes were observed in the rendered markdown documents:

 compare-interventions.md                         |   7 ++-----
 fig/model-choices-rendered-unnamed-chunk-3-1.png | Bin 16407 -> 18757 bytes
 fig/model-choices-rendered-unnamed-chunk-4-1.png | Bin 9072 -> 9164 bytes
 md5sum.txt                                       |   8 ++++----
 model-choices.md                                 |  14 ++------------
 modelling-interventions.md                       |   4 ----
 simulating-transmission.md                       |   4 ----
 7 files changed, 8 insertions(+), 29 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-11-06 13:12:27 +0000

@avallecam
Copy link
Member

this looks interesting! I added this to the maintenance project to make this visible in the coming days

@chartgerink chartgerink force-pushed the let-sandpaper-translate branch from e4ad240 to 95cea05 Compare October 28, 2024 12:24
@Bisaloo Bisaloo force-pushed the let-sandpaper-translate branch from 95cea05 to e68b54d Compare November 6, 2024 11:04
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
@Bisaloo Bisaloo force-pushed the let-sandpaper-translate branch from e68b54d to db0f990 Compare November 6, 2024 13:07
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
@Bisaloo Bisaloo merged commit aff5167 into main Nov 6, 2024
4 checks passed
@Bisaloo Bisaloo deleted the let-sandpaper-translate branch November 6, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants