api: allow tracing sampleRate smaller than 1% #5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5096 +/- ##
==========================================
+ Coverage 66.77% 66.84% +0.06%
==========================================
Files 210 210
Lines 32957 32957
==========================================
+ Hits 22006 22029 +23
+ Misses 9613 9597 -16
+ Partials 1338 1331 -7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
tracing-sampling-fraction
branch
from
e0d2140 to
cef658c
Compare
arkodg
reviewed
Jan 21, 2025
| type ProxyTracing struct { | ||
| // SamplingRate controls the rate at which traffic will be | ||
| // selected for tracing if no prior sampling decision has been made. | ||
| // Defaults to 100, valid values [0-100]. 100 indicates 100% sampling. | ||
| // | ||
| // Only one of SamplingRate or SamplingFraction may be specified. | ||
| // If neither field is specified, 1% of requests will be sampled. |
There was a problem hiding this comment.
is this default 1% sampling already happening today ?
guydc
approved these changes
Jan 21, 2025
EshaanAgg
pushed a commit
to EshaanAgg/gateway
that referenced
this pull request
Jan 22, 2025
* api: allow tracing sampleRate smaller than 1% Signed-off-by: zirain <[email protected]> Signed-off-by: EshaanAgg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #5089