Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes exception from vhds.cc #38267

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Jan 30, 2025

Commit Message: Removes exception from vhds.cc
Additional Description:
Risk Level: low
Testing: existing ones
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Takeshi Yoneda <[email protected]>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38267 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Member Author

cc @alyssawilk

@mathetake mathetake marked this pull request as ready for review January 30, 2025 18:47
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Copy link
Member Author

/retest

@alyssawilk alyssawilk self-assigned this Jan 30, 2025
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's a nice easy fix to clear one more file :-)

@alyssawilk alyssawilk merged commit 107b7e1 into envoyproxy:main Jan 30, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants