Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: stop building libcurl docs #38172

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Jan 24, 2025

This should be turned off as it's not needed.
Ref Homebrew/homebrew-core#205269

Fix #37470

Signed-off-by: Takeshi Yoneda <[email protected]>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38172 was opened by mathetake.

see: more, trace.

@@ -268,6 +268,7 @@ envoy_cmake(
cache_entries = {
"BUILD_CURL_EXE": "off",
"BUILD_TESTING": "off",
"BUILD_LIBCURL_DOCS": "off",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathetake
Copy link
Member Author

cc @phlax

@mathetake mathetake marked this pull request as ready for review January 24, 2025 04:29
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mathetake

@phlax phlax merged commit ae6cb32 into envoyproxy:main Jan 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on macOS 15 with latest 1.32.1
2 participants