mobile: Move --noincompatible_enable_android_toolchain_resolution to mobile-android config #37936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredy Wijaya <[email protected]>
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
Yueren-Wang
pushed a commit
to Yueren-Wang/envoy
that referenced
this pull request
Jan 9, 2025
…mobile-android config (envoyproxy#37936) This moves `--noincompatible_enable_android_toolchain_resolution` to `--config=mobile-android` so that it works on both local and remote builds. Risk Level: low Testing: CI Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Fredy Wijaya <[email protected]> Signed-off-by: Yueren Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
--noincompatible_enable_android_toolchain_resolutionto--config=mobile-androidso that it works on both local and remote builds.Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a