Disable QUIC ACK_FREQUENCY fuzz test #37913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @RyanTheOptimist |
adisuissa
reviewed
Jan 8, 2025
adisuissa
reviewed
Jan 8, 2025
| @@ -316,13 +316,18 @@ QuicPacketizer::QuicPacketPtr QuicPacketizer::serializePacket(const QuicFrame& f | |||
| return serializeMessageFrame(frame.message_frame()); | |||
| case QuicFrame::kNewToken: | |||
| return serializeNewTokenFrame(frame.new_token()); | |||
| #if 0 | |||
| // TODO(martinduke): AckFrequency is undergoing major revision to update to | |||
There was a problem hiding this comment.
I guess there's no tracking issue for QUICHE.
Signed-off-by: Martin Duke <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
martinduke
force-pushed
the
disable-ack-frequency
branch
from
d4ada10 to
446de3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Disable Fuzz testing for legacy QUIC ACK_FREQUENCY frames
Additional Description: The QUICHE ACK_FREQUENCY implementation is badly out of date compared to the spec. Disable Fuzz Tests for the old format to avoid compiler failures while QUICHE development continues.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]