opentelemetrytracer: Log (debug) the number of exported spans #37828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Grassi <[email protected]>
joaopgrassi
force-pushed
the
otel-tracer-log-num-exported-spans
branch
from
586b2d4 to
3528896
Compare
|
CC @wbpcode I thought about adding this, as I have been experiencing some users having problems with Istio where the config "looks OK" but no spans are received by the back-end. Having such log can help in troubleshooting. I saw there's a OTel stat sink, but that can only be exported via gRPC which is not always helpful, specially for those who use a back-end that does not support OTLP/gRPC. I opened a separated issue for it: #37826 |
wbpcode
reviewed
Jan 2, 2025
wbpcode
reviewed
Jan 2, 2025
Signed-off-by: Joao Grassi <[email protected]>
Signed-off-by: Joao Grassi <[email protected]>
Signed-off-by: Joao Grassi <[email protected]>
joaopgrassi
force-pushed
the
otel-tracer-log-num-exported-spans
branch
from
627876c to
00dfe76
Compare
|
Sorry, had to force push because I forgot to sign-off the commits. |
wbpcode
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Log (debug) the number of exported spans
Additional Description:
Adds a debug log message containing the number of (about to be) exported spans. This is helpful in troubleshooting for cases where the configuration looks "correct" but no spans are seen in the tracing back-end. The stats sink could be used, but that only exports via OTLP/gRPC which is not always possible.
Risk Level: Low
Testing: Manual and Unit tests
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]