http2: propagates reset events to CodecEventCallbacks when sending RST_STREAM #37784
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Biren Roy <[email protected]>
Signed-off-by: Biren Roy <[email protected]>
|
note: envoy maintainers will be mostly on vacation until 6th jan |
|
Happy new year! |
|
/assign @alyssawilk |
alyssawilk
reviewed
Jan 8, 2025
Signed-off-by: Biren Roy <[email protected]>
Signed-off-by: Biren Roy <[email protected]>
I added runtime guard |
Signed-off-by: Biren Roy <[email protected]>
alyssawilk
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found this patch useful in our testing.
The delta between the first and second commit demonstrates test coverage for the new code.
The new behavior can be disabled with the runtime guard
envoy.reloadable_features.http2_propagate_reset_events.Commit Message: propagates reset events to CodecEventCallbacks when sending RST_STREAM
Additional Description:
Risk Level: low
Testing: ran unit and integration tests locally
Docs Changes:
Release Notes:
Platform Specific Features:
Runtime guard:
envoy.reloadable_features.http2_propagate_reset_events