Change handling of graceful case of LoadStatsReporting onRemoteClose #37076
CI (Envoy) / Mobile/Perf
skipped
Nov 19, 2024 in 0s
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/37076/main@e614e56)
e614e56 
#37076 merge main@dbddb8a
Change handling of graceful case of LoadStatsReporting onRemoteClose
Reopening this PR
Currently, we treat all remote grpc stream closes as errors, and log warnings and increment failure metrics for every instance. A remote grpc stream close with a 0 code is not a failure, but instead a graceful termination, so it should be a lower log level and should not increment failure metrics.
Commit Message:
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Environment
Request variables
| Key | Value |
|---|---|
| ref | cddf28a |
| sha | e614e56 |
| pr | 37076 |
| base-sha | dbddb8a |
| actor | @briansonnenberg |
| message | Change handling of graceful case of LoadStatsReporting onRemoteClose... |
| started | 1732042070.511899 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 33 |
| patch | 0 |
| dev | true |
Loading