New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Target "envire_pcl" links to: #3

Merged

annaborn merged 1 commit into master from fix_boost_thread_link

Jan 23, 2023

Contributor

Priyanka328 commented Jan 23, 2023

Boost::thread


          fix Target "envire_pcl" links to:

efd2fe1

    Boost::thread

Contributor

annaborn commented Jan 23, 2023

there are two issues in this commit:

envire pcl was missing boost system
there is some issue in rock with local version of findboost.cmake, so find_package(Boost..) will not work with cmake 3.3 if it is called from src/CMakeLists.txt, and not from root CmakeLists.txt.
(FindBoost.cmake rock-core/base-cmake#77)

So I will accept this MR.

annaborn merged commit 788becf into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet