-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to load module data from DDR3 SPD EEPROM #181
Add option to load module data from DDR3 SPD EEPROM #181
Conversation
a2812df
to
cf83ac6
Compare
Some modules' timings seem to be higher than in the datasheets, is there a reason for that? Should we update the timings? For example, MT18KSF1G72HZ for speedgrade 1G4 (DDR3-1333) has For this reason I did not include timing parameters comparisons in the unit tests yet - then most tests would fail. I compare only the geometry from SPD data/our module and I also check the timings directly with those from datasheet. |
@jedrzejboczar: We should also use this work to do a review of the current timings. While doing that, can you modify the values you think should be modified and i'll also review this? Thanks. |
I've updated the timings based on the values extracted from SPD data, but I have some notes. Firstly, for some modules I encountered inconsistencies between Secondly, I see that |
Thanks @jedrzejboczar, this looks good and will be very useful. It's merged and issues have been created for the remaining points: #184 and #185. |
This PR would adds option to load parameters of
SDRAMModule
from raw SPD data.For now this is only implemented for DDR3 memory, but could be later extended for other types.
I've created some tests based on reference SPD contents from Micron's website.
I've also fixed
nrows
inMT8KTF51264
.