fix-subscribe:fixing suscbribe with symbol #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix-subscribe:fixing suscbribe with symbol
update docs for subscribing
merge and adding docs readme
|
i think we can create dev branch for testing it,before merge to main branch |
|
Thanks for pr, but I can't accept it as is. There is no tests, some strange files like |
i think we can create new branch like dev branch |
CODLOP
suggested changes
Nov 27, 2023
| volume: event.params.p[1].sds_1.s[0].v[5], | ||
| symbol | ||
| } | ||
| // callback(candles) |
There was a problem hiding this comment.
i don't know why you comment the callback !!
| ]) | ||
| connection.subscribe((event: any) => { | ||
| if (event.name = "event") { | ||
| if (event.params.p[1].sds_1?.s !== undefined) { |
There was a problem hiding this comment.
all event.params.p should be event.params
| ]) | ||
|
|
||
|
|
||
| export async function connectAndSubscribe({ connection, symbols, timeframe = 1 }: GetCandlesParams) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i just add subscribe with symbol and remove unused code