This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
Lazy load emmet.js library to reduce startup time #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a motivation this is not being merged yet? |
|
Changes in core Emmet are workarounds, not solution. A better solution is to refactor core for pure CommonJS modules and use Browserfy to bundle Emmet core as a single module. Do you restart Atom often? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
Speed up by lazy loading emmet core library.
This requires emmetio/emmet#394 to be merged.
After:
TODO:
Thanks!