-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Models and Database urls/Values not picked from Character File - Changes Core Logic #3480
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Relates to
This PR addresses issues where variables and values were not correctly retrieved from the character configuration file for various models and adapters and plugins.
Risks
Medium
Background
What does this PR do?
This PR refactors the models.ts file by transitioning from constant retrieval of model configurations to a function-based approach that utilizes the runtime variable. This change ensures that model settings can be dynamically retrieved based on user-defined configurations. Also at many places only process.env was used for example for database values etc which has been changed to using settings using character or runtime.
What kind of change is this?
Improvements, Bug Fixes: This update enhances the flexibility of model configurations and resolves existing bugs related to static model names.
Why are we doing this? Any context or related work?
Users have reported issues where they expect model names and configurations to be adjustable via the character file, but the previous implementation fixed many model names. This change is crucial to allow users to customize model settings effectively, ensuring that the application behaves as expected and aligns with user configurations.
Documentation changes needed?
Yes: Documentation will need to be updated to reflect the new function-based model retrieval approach and how users can configure models through the character file.
Testing
Where should a reviewer start?
Check for any regressions in functionality related to model retrieval.
Detailed testing steps
Screenshots
Deploy Notes
Database changes
Deployment instructions
Discord username
bchief