-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add drizzle psg #3403
base: v2-develop
Are you sure you want to change the base?
feat: add drizzle psg #3403
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This is great. Some thoughts -> Let's get rid of RAGKnowledge. Thinking longterm, Knowledge is already RAG. Knowledge should be memories, and if there are special search functions or things that RAGKnowledge is doing that memories aren't, we should think of that as being a dynamically injected context provider, I think, not part of core. Like you should be able to add a custom knowledge system if you want, but that should be using the primitives we offer. -> Database schema change. IMO we can ship without this, then make an import/export script Gonna pull this into |
I've removed the knowledge-related code from Should we also remove it from schema.sql and init.sql? I notice it's still present in SQLite. For merging to v2-develop: we'll need to configure both the connection and embedding settings. |
Database Adapter Implementation with Drizzle ORM
Pull Request Overview
Relates to
Issue: Database Adapter Implementation with Drizzle ORM
Risks
Risk Level: Medium
Background
What does this PR do?
Type of Change
Key Discussion Points
1. Embedding Configuration
The
embedding.ts
file has been removed but embedding configuration is still needed. Current implementation relies ongetEmbeddingConfig()
which needs to be set before initialization.Proposal: Configuration Injection Pattern
2. Multiple Driver Support
Current implementation is PostgreSQL-specific. Need to discuss strategy for supporting multiple database drivers.
3. RAGKnowledge Compatibility
RAGKnowledge functionality appears to be removed in v2-develop.
Discussion Points:
Implementation Details
Database Schema
The implementation includes several key tables:
accounts
memories
rooms
goals
logs
participants
relationships
knowledge
cache
Vector Operations
Supports vector operations through PostgreSQL extensions:
But needs proper setup for embedding settings.
Embedding Provider Configuration
Current implementation:
Reference Implementations
Drizzle ORM Implementation (v1 develop)
Branch: https://github.com/0xbbjoker/eliza/tree/0xbbjoker/drizzle-orm
Experimental Bun SQL Implementation
Branch: https://github.com/0xbbjoker/eliza/tree/bbopar/test-bun-sql
Contact
Discord: .0xbbjoker