Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Standardization of Security Check Identifiers across GoPlus plugin #3164

Merged
merged 6 commits into from
Feb 3, 2025
Merged

chore: Standardization of Security Check Identifiers across GoPlus plugin #3164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ec44bc
fix ADRESS_SECURITY_CHECK in GoplusSecurityService.ts
Marcofann Feb 2, 2025
1435c3f
fix ADRESS_SECURITY_CHECK in index.ts
Marcofann Feb 2, 2025
3392c59
fix ADRESS_SECURITY_CHECK in GoPlusManage.ts
Marcofann Feb 2, 2025
761807b
fix ADRESS_SECURITY_CHECK in README.md
Marcofann Feb 2, 2025
a7c61da
Update index.ts
Marcofann Feb 3, 2025
b3b7ccc
Merge branch 'develop' into fix/fix
shakkernerd Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-goplus/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ The plugin supports various networks including:
- `APPROVAL_SECURITY_CHECK`: Smart contract approval analysis

### Account & Address Security
- `ADRESS_SECURITY_CHECK`: Malicious address detection
- `ADDRESS_SECURITY_CHECK`: Malicious address detection
- `ACCOUNT_ERC20_SECURITY_CHECK`: ERC20 token security
- `ACCOUNT_ERC721_SECURITY_CHECK`: NFT asset security
- `ACCOUNT_ERC1155_SECURITY_CHECK`: Multi-token asset security
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-goplus/src/lib/GoPlusManage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const GoPlusType = {
SUITOKEN_SECURITY_CHECK: "SUITOKEN_SECURITY_CHECK",
RUGPULL_SECURITY_CHECK: "RUGPULL_SECURITY_CHECK",
NFT_SECURITY_CHECK: "NFT_SECURITY_CHECK",
ADRESS_SECURITY_CHECK: "ADRESS_SECURITY_CHECK",
ADDRESS_SECURITY_CHECK: "ADDRESS_SECURITY_CHECK",
APPROVAL_SECURITY_CHECK: "APPROVAL_SECURITY_CHECK",
ACCOUNT_ERC20_SECURITY_CHECK: "ACCOUNT_ERC20_SECURITY_CHECK",
ACCOUNT_ERC721_SECURITY_CHECK: "ACCOUNT_ERC721_SECURITY_CHECK",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-goplus/src/services/GoplusSecurityService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class GoplusSecurityService extends Service implements IGoplusSecuritySer
case GoPlusType.NFT_SECURITY_CHECK:
checkResult = await goPlusManage.nftSecurity(obj.network, obj.token);
break;
case GoPlusType.ADRESS_SECURITY_CHECK:
case GoPlusType.ADDRESS_SECURITY_CHECK:
checkResult = await goPlusManage.addressSecurity(obj.wallet);
break;
case GoPlusType.APPROVAL_SECURITY_CHECK:
Expand Down
6 changes: 3 additions & 3 deletions packages/plugin-goplus/src/templates/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,14 @@ Available actions:
\`\`\`


- [ADRESS_SECURITY_CHECK]
- [ADDRESS_SECURITY_CHECK]
Description: Analysis of specific address security status, detecting known malicious addresses, scam addresses or high-risk addresses
Keywords: wallet security, malicious address, scam address, blacklist
Respond with a JSON markdown block containing only the extracted values:

\`\`\`json
{
"type": "ADRESS_SECURITY_CHECK"
"type": "ADDRESS_SECURITY_CHECK",
"network": "1", //default: 1 (Ethereum:1, Optimism:10, Cronos:25, BSC:56, Gnosis:100, HECO:128, Polygon:137, Fantom:250, KCC:321, zkSync Era:324, FON:201022, Arbitrum:42161, Avalanche:43114, Linea Mainnet:59144, Tron:tron, Scroll:534352, opBNB:204, Base:8453, Solana:solana)
"wallet": "" | null,
}
Expand Down Expand Up @@ -206,4 +206,4 @@ Instructions:
3. **Formulate a Clear Response**: Combine the action type, extracted information, and an analysis of the results. Provide a clear, concise response based on the security context. Focus on delivering the most relevant answer without unnecessary detail.
- Only reply with your conclusion.
- Do not discuss the safety aspects of the action; just focus on identifying and pointing out any risks.
- Tailor your response to the user’s request, focusing on their specific query.`
- Tailor your response to the user’s request, focusing on their specific query.`