-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Make generateNewTweet
public
#1902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hazelnutcloud! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!
looks valid request! #1901 ? shall we merge @odilitime @shakkernerd |
Please include your thinking/reasoning why this change, so everyone can learn what you’ve learned |
I want to use this in an externally managed cron job. The original issue discusses it in more detail #1901 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the idea of wanting to externally control generateNewTweet
isn't a bad one.
generateNewTweet
publicgenerateNewTweet
public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go
Relates to
closes #1901
Risks
Background
What does this PR do?
Makes the
generateNewTweet
method of the TwitterPostClient class publicWhat kind of change is this?
Improvements
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Detailed testing steps