Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make generateNewTweet public #1902

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

hazelnutcloud
Copy link
Contributor

@hazelnutcloud hazelnutcloud commented Jan 6, 2025

Relates to

closes #1901

Risks

Background

What does this PR do?

Makes the generateNewTweet method of the TwitterPostClient class public

What kind of change is this?

Improvements

Documentation changes needed?

My changes do not require a change to the project documentation.

Testing

Where should a reviewer start?

Detailed testing steps

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hazelnutcloud! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@wtfsayo
Copy link
Member

wtfsayo commented Jan 6, 2025

looks valid request! #1901 ? shall we merge @odilitime @shakkernerd

odilitime
odilitime previously approved these changes Jan 7, 2025
@odilitime odilitime changed the base branch from main to develop January 7, 2025 16:56
@odilitime odilitime dismissed their stale review January 7, 2025 16:56

The base branch was changed.

@odilitime
Copy link
Collaborator

Please include your thinking/reasoning why this change, so everyone can learn what you’ve learned

@hazelnutcloud
Copy link
Contributor Author

I want to use this in an externally managed cron job. The original issue discusses it in more detail #1901 (comment)

shakkernerd
shakkernerd previously approved these changes Jan 8, 2025
Copy link
Member

@shakkernerd shakkernerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the idea of wanting to externally control generateNewTweet isn't a bad one.

@shakkernerd shakkernerd changed the title Make generateNewTweet public chore: Make generateNewTweet public Jan 8, 2025
Copy link
Member

@wtfsayo wtfsayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@shakkernerd shakkernerd merged commit 1c797e9 into elizaOS:develop Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make TwitterPostClient.generateNewTweet public
5 participants