feat: Add Extra Multimedia Support for Telegram Client #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'develop' of github.com:elizaOS/eliza: (478 commits) chore: bump version to v.0.1.7 fix: generatioon tests for trimTokens chore: install with no frozen-lockfile flag Revert "fix(postgres): Handle vector extension creation properly (elizaOS#1561)" chore: remove unused import and var Removed FerePro plugin fix: line break handling in chat fix: handle env using runtime getSetting function feat: add validation to trimTokens feat: add JsDoc to trimTokens function Move encoding into try block to handle potential errors during model encoding. fall back if unsupported type fix(client): improve Windows compatibility for Vite dev server remove tokenizer service clean code restore test clean code move trimTokens to core feat: add Serbian README translation and enhance main README with new features and setup instructions use elizaLogger ...
- default every other mediaType to document except audio, image, video
tcm390
requested changes
Jan 8, 2025
There was a problem hiding this comment.
The Telegram client code looks good to me overall. I’ve left a few small change requests. Could you also provide a screenshot showing each type of media being successfully sent by the client? Lastly, could you please remove the sui plugin in this PR, as it doesn’t appear to be related? Thank you!
| @@ -660,7 +661,7 @@ export class MessageManager { | |||
| this.runtime.character.templates | |||
| ?.telegramShouldRespondTemplate || | |||
| this.runtime.character?.templates?.shouldRespondTemplate || | |||
| composeRandomUser(telegramShouldRespondTemplate, 2), | |||
There was a problem hiding this comment.
Could you clarify the reasoning behind removing the composeRandomUser function? I'm curious about the context for this change and whether there's an alternative approach we should be using.
| } | ||
| }); | ||
| } else { | ||
| const chunks = this.splitMessage(content.text); | ||
| const sentMessages: Message.TextMessage[] = []; | ||
|
|
||
| for (let i = 0; i < chunks.length; i++) { | ||
| const chunk = escapeMarkdown(chunks[i]); |
There was a problem hiding this comment.
Could you clarify the reasoning behind removing the escapeMarkdown function?
odilitime
changed the title
|
It's been remade with: #2510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Risks
Background
What does this PR do?
Adds more multimedia support to tg client. video, audio, and documents
What kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps
Discord username
@em.eieiron