clean up and lint

elizaOS · Feb 11, 2025 · 048fafa · 048fafa
1 parent 75ab478
commit 048fafa
Show file tree

Hide file tree

Showing 94 changed files with 979 additions and 606 deletions.
diff --git a/biome.json b/biome.json
@@ -13,12 +13,10 @@
                 "noPrototypeBuiltins": "warn",
                 "noDuplicateObjectKeys": "warn",
                 "noGlobalIsNan": "warn",
-                "noDuplicateFontNames": "warn",
                 "noSelfCompare": "warn",
                 "noDoubleEquals": "warn",
                 "noImplicitAnyLet": "warn",
                 "noAssignInExpressions": "warn",
-                "noExportsInTest": "warn",
                 "noConstEnum": "warn",
                 "noEmptyInterface": "warn"
             },
@@ -33,24 +31,19 @@
             "style": {
                 "useConst": "warn",
                 "useTemplate": "warn",
-                "useImportType": "warn",
-                "useNodejsImportProtocol": "warn",
                 "noUselessElse": "warn",
                 "useSelfClosingElements": "warn",
-                "useNumberNamespace": "warn",
                 "noUnusedTemplateLiteral": "warn",
                 "noInferrableTypes": "warn",
                 "noNonNullAssertion": "warn",
                 "noParameterAssign": "warn",
                 "useDefaultParameterLast": "warn",
                 "useExponentiationOperator": "warn",
                 "noVar": "warn",
-                "useSingleVarDeclarator": "warn",
-                "useExportType": "warn"
+                "useSingleVarDeclarator": "warn"
             },
             "a11y": {
                 "useAltText": "warn",
-                "useFocusableInteractive": "warn",
                 "useMediaCaption": "warn",
                 "noSvgWithoutTitle": "warn",
                 "useKeyWithClickEvents": "warn"
@@ -65,7 +58,6 @@
                 "noStaticOnlyClass": "warn",
                 "noThisInStatic": "warn",
                 "noUselessConstructor": "warn",
-                "noUselessTernary": "warn",
                 "noUselessSwitchCase": "warn",
                 "noUselessCatch": "warn"
             },

diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "scripts": {
     "format": "biome format --write .",
     "cli": "bun --filter=@elizaos/cli cli",
-    "lint": "biome lint . --write",
+    "lint": "turbo run lint:fix --filter=./packages/*",
     "check": "biome check --apply .",
     "preinstall": "npx only-allow bun",
     "build": "turbo run build --filter=./packages/core && turbo run build --filter=./packages/*",

diff --git a/packages/agent/src/api.ts b/packages/agent/src/api.ts
@@ -1,11 +1,11 @@
 import {
     type Character,
     getEnvVariable,
-    IAgentRuntime,
-    ITeeLogService,
+    type IAgentRuntime,
+    type ITeeLogService,
     logger,
     ServiceType,
-    TeeLogQuery,
+    type TeeLogQuery,
     type UUID,
     validateCharacterConfig,
     validateUuid

diff --git a/packages/agent/src/defaultCharacter.ts b/packages/agent/src/defaultCharacter.ts
@@ -1,4 +1,4 @@
-import { type Character } from "@elizaos/core";
+import type { Character } from "@elizaos/core";
 
 export const defaultCharacter: Character = {
   name: "Eliza",

diff --git a/packages/agent/src/plugins.test.ts b/packages/agent/src/plugins.test.ts
@@ -8,7 +8,7 @@ import {
     DbCacheAdapter,
     logger,
     stringToUuid,
-    TestSuite,
+    type TestSuite,
     type IAgentRuntime
 } from "@elizaos/core";
 import { afterAll, beforeAll, describe, it } from 'vitest';

diff --git a/packages/agent/src/reply.ts b/packages/agent/src/reply.ts
@@ -1,10 +1,10 @@
-import {
-    type Action,
-    type ActionExample,
-    type HandlerCallback,
-    type IAgentRuntime,
-    type Memory,
-    type State,
+import type {
+    Action,
+    ActionExample,
+    HandlerCallback,
+    IAgentRuntime,
+    Memory,
+    State,
 } from "@elizaos/core";
 
 const replyAction = {

diff --git a/packages/cli/src/commands/agent.ts b/packages/cli/src/commands/agent.ts
@@ -62,7 +62,7 @@ agent
     try {
       // If input is a number, get agent ID from index
       if (!isNaN(Number(agentIdOrIndex))) {
-        agentIdOrIndex = await getAgentIdFromIndex(parseInt(agentIdOrIndex))
+        agentIdOrIndex = await getAgentIdFromIndex(Number.parseInt(agentIdOrIndex))
       }
 
       const response = await fetch(`${AGENT_RUNTIME_URL}/agents/${agentIdOrIndex}`)
@@ -122,7 +122,7 @@ agent
   .action(async (agentIdOrIndex) => {
     try {
       if (!isNaN(Number(agentIdOrIndex))) {
-        agentIdOrIndex = await getAgentIdFromIndex(parseInt(agentIdOrIndex))
+        agentIdOrIndex = await getAgentIdFromIndex(Number.parseInt(agentIdOrIndex))
       }
 
       const response = await fetch(`${AGENT_RUNTIME_URL}/agents/${agentIdOrIndex}/stop`, {
@@ -146,7 +146,7 @@ agent
   .action(async (agentIdOrIndex) => {
     try {
       if (!isNaN(Number(agentIdOrIndex))) {
-        agentIdOrIndex = await getAgentIdFromIndex(parseInt(agentIdOrIndex))
+        agentIdOrIndex = await getAgentIdFromIndex(Number.parseInt(agentIdOrIndex))
       }
 
       const response = await fetch(`${AGENT_RUNTIME_URL}/agents/${agentIdOrIndex}`, {
@@ -171,7 +171,7 @@ agent
   .action(async (agentIdOrIndex, configPath) => {
     try {
       if (!isNaN(Number(agentIdOrIndex))) {
-        agentIdOrIndex = await getAgentIdFromIndex(parseInt(agentIdOrIndex))
+        agentIdOrIndex = await getAgentIdFromIndex(Number.parseInt(agentIdOrIndex))
       }
 
       const config = JSON.parse(fs.readFileSync(configPath, 'utf8'))

diff --git a/packages/core/__tests__/knowledge.test.ts b/packages/core/__tests__/knowledge.test.ts
@@ -1,7 +1,7 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import knowledge from "../src/knowledge";
 import type { AgentRuntime } from "../src/runtime";
-import { type Memory } from "../src/types";
+import type { Memory } from "../src/types";
 
 vi.mock("../generation", () => ({
     splitChunks: vi.fn().mockImplementation(async (text) => [text]),

diff --git a/packages/core/__tests__/mockCharacter.ts b/packages/core/__tests__/mockCharacter.ts
@@ -1,4 +1,4 @@
-import { type Character } from "@elizaos/core";
+import type { Character } from "@elizaos/core";
 
 export const mockCharacter: Character = {
     name: "Eliza",

diff --git a/packages/core/__tests__/runtime.test.ts b/packages/core/__tests__/runtime.test.ts
@@ -1,11 +1,11 @@
 import { beforeEach, describe, expect, it, test, vi } from "vitest";
 import { AgentRuntime } from "../src/runtime";
-import {
-    type Action,
-    type IDatabaseAdapter,
-    type IMemoryManager,
-    type Memory,
-    type UUID
+import type {
+    Action,
+    IDatabaseAdapter,
+    IMemoryManager,
+    Memory,
+    UUID
 } from "../src/types";
 
 // Mock dependencies with minimal implementations

diff --git a/packages/core/src/runtime.ts b/packages/core/src/runtime.ts
@@ -44,8 +44,8 @@ import {
     type Provider,
     type State,
     type UUID,
-    ServiceType,
-    Service
+    type ServiceType,
+    type Service
 } from "./types.ts";
 import { stringToUuid } from "./uuid.ts";
 

diff --git a/packages/core/src/test_resources/createRuntime.ts b/packages/core/src/test_resources/createRuntime.ts
@@ -1,7 +1,7 @@
 import { SqliteDatabaseAdapter, loadVecExtensions } from "@elizaos-plugins/sqlite";
 import type { DatabaseAdapter } from "../database.ts";
 import { AgentRuntime } from "../runtime.ts";
-import { type Action, type Evaluator, type Provider } from "../types.ts";
+import type { Action, Evaluator, Provider } from "../types.ts";
 import {
     zeroUuid
 } from "./constants.ts";

diff --git a/packages/plugin-anthropic/biome.json b/packages/plugin-anthropic/biome.json
@@ -0,0 +1,40 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.5.3/schema.json",
+  "extends": ["../../biome.json"],
+  "organizeImports": {
+    "enabled": false
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "correctness": {
+        "noUnusedVariables": "error"
+      },
+      "suspicious": {
+        "noExplicitAny": "error"
+      },
+      "style": {
+        "useConst": "error"
+      }
+    }
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 4,
+    "lineWidth": 100
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single"
+    }
+  },
+  "files": {
+    "ignore": [
+      "dist/**/*",
+      "extra/**/*",
+      "node_modules/**/*"
+    ]
+  }
+}
diff --git a/packages/plugin-anthropic/src/index.ts b/packages/plugin-anthropic/src/index.ts
@@ -1,7 +1,7 @@
 import { anthropic } from "@ai-sdk/anthropic";
 import type { Plugin } from "@elizaos/core";
 import {
-  GenerateTextParams,
+  type GenerateTextParams,
   ModelClass
 } from "@elizaos/core";
 import { generateText } from "ai";

diff --git a/packages/plugin-bootstrap/biome.json b/packages/plugin-bootstrap/biome.json
@@ -0,0 +1,40 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.5.3/schema.json",
+  "extends": ["../../biome.json"],
+  "organizeImports": {
+    "enabled": false
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "correctness": {
+        "noUnusedVariables": "error"
+      },
+      "suspicious": {
+        "noExplicitAny": "error"
+      },
+      "style": {
+        "useConst": "error"
+      }
+    }
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 4,
+    "lineWidth": 100
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single"
+    }
+  },
+  "files": {
+    "ignore": [
+      "dist/**/*",
+      "extra/**/*",
+      "node_modules/**/*"
+    ]
+  }
+}
diff --git a/packages/plugin-bootstrap/src/providers/facts.ts b/packages/plugin-bootstrap/src/providers/facts.ts
@@ -1,7 +1,7 @@
 import type { Memory, Provider, State } from "@elizaos/core";
 import {
     formatMessages,
-    IAgentRuntime,
+    type IAgentRuntime,
     MemoryManager,
     ModelClass
 } from "@elizaos/core";

diff --git a/packages/plugin-discord/biome.json b/packages/plugin-discord/biome.json
@@ -0,0 +1,40 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.5.3/schema.json",
+  "extends": ["../../biome.json"],
+  "organizeImports": {
+    "enabled": false
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "correctness": {
+        "noUnusedVariables": "error"
+      },
+      "suspicious": {
+        "noExplicitAny": "error"
+      },
+      "style": {
+        "useConst": "error"
+      }
+    }
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 4,
+    "lineWidth": 100
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single"
+    }
+  },
+  "files": {
+    "ignore": [
+      "dist/**/*",
+      "extra/**/*",
+      "node_modules/**/*"
+    ]
+  }
+}
diff --git a/packages/plugin-discord/src/actions/reply.ts b/packages/plugin-discord/src/actions/reply.ts
@@ -1,9 +1,9 @@
-import {
-    type Action,
-    type HandlerCallback,
-    type IAgentRuntime,
-    type Memory,
-    type State
+import type {
+    Action,
+    HandlerCallback,
+    IAgentRuntime,
+    Memory,
+    State
 } from "@elizaos/core";
 
   const replyAction = {

diff --git a/packages/plugin-discord/src/index.ts b/packages/plugin-discord/src/index.ts
@@ -1,7 +1,7 @@
 import {
     logger,
     stringToUuid,
-    TestSuite,
+    type TestSuite,
     type Character,
     type Client as ElizaClient,
     type IAgentRuntime,
@@ -28,7 +28,7 @@ import { MessageManager } from "./messages.ts";
 import channelStateProvider from "./providers/channelState.ts";
 import voiceStateProvider from "./providers/voiceState.ts";
 import reply from "./actions/reply.ts";
-import { IDiscordClient } from "./types.ts";
+import type { IDiscordClient } from "./types.ts";
 import { VoiceManager } from "./voice.ts";
 
 export class DiscordClient extends EventEmitter implements IDiscordClient {

diff --git a/packages/plugin-discord/src/messages.ts b/packages/plugin-discord/src/messages.ts
@@ -9,7 +9,7 @@ import {
     ChannelType,
     type Client,
     type Message as DiscordMessage,
-    TextChannel,
+    type TextChannel,
 } from "discord.js";
 import { AttachmentManager } from "./attachments.ts";
 import {

diff --git a/packages/plugin-discord/src/types.ts b/packages/plugin-discord/src/types.ts
@@ -1,8 +1,8 @@
-import {
-    type Character,
-    type IAgentRuntime
+import type {
+    Character,
+    IAgentRuntime
 } from "@elizaos/core";
-import {
+import type {
     Client
 } from "discord.js";