Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some build warnings #71

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix some build warnings #71

merged 2 commits into from
Dec 16, 2024

Conversation

ryonakano
Copy link
Member

After

user@VirtualBox-36929c8d:~/work/switchboard-plug-wacom$ ninja -C builddir/ install
ninja: Entering directory `builddir/'
[1/15] Compiling Vala source ../src/Backend/Device.vala ../src/Backend/DeviceManager.vala ../src/Backend/DeviceManage...w.vala ../src/Views/TabletView.vala ../src/Widgets/DrawingArea.vala ../src/MainPage.vala ../src/Plug.vala Config.vala
../src/Views/StylusView.vala:107.32-107.47: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
  107 |         var button_combo = new Gtk.ComboBoxText () {
      |                                ^~~~~~~~~~~~~~~~     
../src/Views/StylusView.vala:107.13-107.24: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
  107 |         var button_combo = new Gtk.ComboBoxText () {
      |             ^~~~~~~~~~~~                            
../src/Views/TabletView.vala:43.5-43.48: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
   43 |     private Gtk.ComboBoxText tracking_mode_combo;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../src/Views/TabletView.vala:50.35-50.50: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
   50 |         tracking_mode_combo = new Gtk.ComboBoxText ();
      |                                   ^~~~~~~~~~~~~~~~    
Compilation succeeded - 4 warning(s)

Before

Latest main (06e3765)

user@VirtualBox-36929c8d:~/work/switchboard-plug-wacom$ ninja -C builddir/ install
ninja: Entering directory `builddir/'
[1/15] Compiling Vala source ../src/Backend/Device.vala ../src/Backend/DeviceManager.vala ../src/Backend/DeviceManage...w.vala ../src/Views/TabletView.vala ../src/Widgets/DrawingArea.vala ../src/MainPage.vala ../src/Plug.vala Config.vala
../src/Backend/DeviceManagerWayland.vala:100.17-100.32: note: Assignment: Unsafe conversion from `int' to `Wacom.Backend.Device.DeviceType'
  100 |                 type |= (1 << i);
      |                 ^~~~~~~~~~~~~~~~ 
../src/Backend/DeviceManagerWayland.vala:152.25-152.68: warning: Access to possible `null'. Perform a check or use an unsafe cast.
  152 |         var node_path = (device as Gdk.Wayland.Device).get_node_path ();
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~    
../src/Backend/WacomToolMap.vala:247.21-247.88: warning: unhandled error `WacomException'
  247 |                     throw new WacomException.LIBWACOM_ERROR (error.get_message () ?? "");
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../src/Views/StylusView.vala:107.32-107.47: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
  107 |         var button_combo = new Gtk.ComboBoxText () {
      |                                ^~~~~~~~~~~~~~~~     
../src/Views/StylusView.vala:107.13-107.24: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
  107 |         var button_combo = new Gtk.ComboBoxText () {
      |             ^~~~~~~~~~~~                            
../src/Views/TabletView.vala:43.5-43.48: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
   43 |     private Gtk.ComboBoxText tracking_mode_combo;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../src/Views/TabletView.vala:50.35-50.50: warning: `Gtk.ComboBoxText' has been deprecated since 4.10
   50 |         tracking_mode_combo = new Gtk.ComboBoxText ();
      |                                   ^~~~~~~~~~~~~~~~    
Compilation succeeded - 6 warning(s)

@stsdc stsdc self-requested a review December 16, 2024 16:02
@stsdc stsdc merged commit db18e22 into main Dec 16, 2024
4 checks passed
@stsdc stsdc deleted the ryonakano/fix-warnings branch December 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants