Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup stripe auto tax for checkout #138

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Setup stripe auto tax for checkout #138

wants to merge 3 commits into from

Conversation

btkostner
Copy link
Contributor

This PR sets up Stripe taxes for checkout.

image

One regression, because the total is generated after we create the printful order, the total on printful's side will not be accurate. This can be remedied by dropping the stripe library we are currently using and rolling our own API client.

Also note, the tax that Stripe is giving us is less than what Printful was. For my address it comes out to $2.84 in stripe and $7.43 with Printful. I'm going to guess that's due to our origin address switching from what ever Printful uses to the one we have on file on Stripe.

And lastly, we will need to add registrations to start collecting taxes in areas: https://stripe.com/docs/tax/set-up

@btkostner
Copy link
Contributor Author

Partially fixes #86 by having tax calculated after discount.

@btkostner
Copy link
Contributor Author

Fixes #85 once registration is added for EU countries

@btkostner
Copy link
Contributor Author

We need to figure out what warehouse printful will use to fulfill an order, and use that address as the shipping address from Stripe's side. This will give us a more accurate VAT and tax information.

@btkostner btkostner marked this pull request as draft November 18, 2021 04:15
@btkostner
Copy link
Contributor Author

This is now a WIP PR. The scope has expanded to include:

  • the shipping selector in stripe checkout
  • no longer having to draft orders and cancel them later on. They are created after payment is made
  • async payment methods will now work
  • discount codes apply correctly

TODO:

  • VAT is not being calculated for addresses. Need to talk to Stripe about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant