Make the id_token optional on upstream OAuth 2.0 providers
#3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to use non-OIDC providers as upstream OAuth 2.0 providers, like GitHub.
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
f8d2823
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef0f8a47.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-upstream-oauth-id-t.matrix-authentication-service-docs.pages.dev |
sandhose
commented
Nov 28, 2024
| let token_request = http_client.post(token_endpoint.as_str()); | ||
| let token_request = http_client | ||
| .post(token_endpoint.as_str()) | ||
| .header(ACCEPT, APPLICATION_JSON.as_ref()); |
There was a problem hiding this comment.
GitHub will return us a URL-encoded form if we don't do this. OAuth 2.0 expects to always return application/json, but also for the relying party to ask for it.
sandhose
added
the
A-Upstream-OAuth
sandhose
changed the title
id_token optional on upstream OAuth 2.0 providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use non-OIDC providers as upstream OAuth 2.0 providers, like GitHub.
Helps with #2080