Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset/restore scroll when navigating through the app #3410

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Oct 23, 2024

Fixes #1844

This does two things:

  • add the scroll restoration utility, so that when the user navigates forward/backward with history, it restores where they were looking
  • add a resetScroll attribute to sessions pagination buttons, so that it 'scrolls' back to the top of the page

Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2024

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d68724f
Status: ✅  Deploy successful!
Preview URL: https://dd7f7267.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-frontend-scroll-res.matrix-authentication-service-docs.pages.dev

View logs

@sandhose sandhose enabled auto-merge (squash) October 23, 2024 08:56
@sandhose sandhose merged commit 1fedb3c into main Oct 23, 2024
17 checks passed
@sandhose sandhose deleted the quenting/frontend/scroll-restoration branch October 23, 2024 09:04
@sandhose sandhose added the T-Enhancement New feature of request label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New feature of request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: App sessions list does not scroll to top after paging
1 participant