Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make server port configurable through environment variable LK_JWT_PORT, default 8080 #17

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Make server port configurable through environment variable LK_JWT_PORT, default 8080 #17

merged 2 commits into from
Mar 19, 2024

Conversation

rockaport
Copy link
Contributor

fixes #16

fkwp
fkwp requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rockaport ,

thx for the contribution. In general, lgtm. One small nit. Can you pls update README.md as well?

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rockaport
Copy link
Contributor Author

Hi @rockaport ,

thx for the contribution. In general, lgtm. One small nit. Can you pls update README.md as well?

Done, thanks for the review.

@fkwp fkwp merged commit 94fa50e into element-hq:main Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkwp fkwp fkwp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make server port configurable, default 8080
3 participants
@rockaport @CLAassistant @fkwp