-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: add blog post for migrating to WebContentsView #667
Conversation
Deploying electron-website with Cloudflare Pages
|
title: Migrating from BrowserView to WebContentsView | ||
date: 2024-11-11T00:00:00.000Z | ||
authors: yangannyx | ||
slug: migrate-to-webcontentsview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it alright that the slug doesn't exactly match the title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is precedent for this in a few of our blog files, for a recent example, so I would say it is fine.
The "Check Blog Links" failure is a false positive since it's a link to this blog post which obviously isn't published yet. There are some lint failures need to be resolved. |
Fixed up the lint issues, think this should be good to go! |
6582ea6
to
9746dde
Compare
Looks like the latest deploy failed btw. You can't see the Cloudflare Pages logs online (I think access is restricted), but I see a warning when building locally:
|
Co-authored-by: Erick Zhao <[email protected]>
Co-authored-by: Erick Zhao <[email protected]>
d61bd6a
to
7668963
Compare
Ah ok, gonna switch back to using the full link. @erickzhao , I saw the summer of code pr used a relative path to a new post being introduced in that pr. Did you do anything special to get that to pass? |
Ah nvm, I just needed to include |
Publishes proposed doc for migrating from BrowserView to WebContentsView
@electron/docs