Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add blog post for migrating to WebContentsView #667

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

yangannyx
Copy link
Member

Publishes proposed doc for migrating from BrowserView to WebContentsView
@electron/docs

@yangannyx yangannyx requested a review from a team as a code owner November 11, 2024 17:40
Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2024

Deploying electron-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8175bae
Status: ✅  Deploy successful!
Preview URL: https://f759a1c5.electron-website.pages.dev
Branch Preview URL: https://anny-blog-migrate-to-webcont.electron-website.pages.dev

View logs

title: Migrating from BrowserView to WebContentsView
date: 2024-11-11T00:00:00.000Z
authors: yangannyx
slug: migrate-to-webcontentsview
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it alright that the slug doesn't exactly match the title?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is precedent for this in a few of our blog files, for a recent example, so I would say it is fine.

@dsanders11
Copy link
Member

The "Check Blog Links" failure is a false positive since it's a link to this blog post which obviously isn't published yet.

There are some lint failures need to be resolved.

@yangannyx
Copy link
Member Author

Fixed up the lint issues, think this should be good to go!

@yangannyx yangannyx force-pushed the anny/blog-migrate-to-webcontentsview branch from 6582ea6 to 9746dde Compare November 12, 2024 11:10
@erickzhao erickzhao changed the title docs: add blog post for migrating to WebContentsView blog: add blog post for migrating to WebContentsView Nov 13, 2024
blog/migrate-to-webcontentsview.md Outdated Show resolved Hide resolved
blog/migrate-to-webcontentsview.md Outdated Show resolved Hide resolved
blog/migrate-to-webcontentsview.md Show resolved Hide resolved
@erickzhao
Copy link
Member

Looks like the latest deploy failed btw. You can't see the Cloudflare Pages logs online (I think access is restricted), but I see a warning when building locally:

[WARNING] Docusaurus found broken links!

Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.

Exhaustive list of all broken links found:
- Broken link on source page path = /blog:
   -> linking to ./migrate-to-webcontentsview (resolved as: /migrate-to-webcontentsview)
- Broken link on source page path = /blog/tags/release:
   -> linking to ./migrate-to-webcontentsview (resolved as: /blog/tags/migrate-to-webcontentsview)

@yangannyx yangannyx force-pushed the anny/blog-migrate-to-webcontentsview branch from d61bd6a to 7668963 Compare November 14, 2024 11:35
@yangannyx
Copy link
Member Author

The "Check Blog Links" failure is a false positive since it's a link to this blog post which obviously isn't published yet.

Ah ok, gonna switch back to using the full link. @erickzhao , I saw the summer of code pr used a relative path to a new post being introduced in that pr. Did you do anything special to get that to pass?

@yangannyx yangannyx requested a review from erickzhao November 14, 2024 11:40
@yangannyx
Copy link
Member Author

Did you do anything special to get that to pass?

Ah nvm, I just needed to include .md in the file path

@yangannyx yangannyx merged commit d37d744 into main Nov 15, 2024
5 checks passed
@yangannyx yangannyx deleted the anny/blog-migrate-to-webcontentsview branch November 15, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants