chore: use @napi-rs/lzma to replace lzma-native

[Brooooooklyn]

See https://github.com/Brooooooklyn/lzma

@napi-rs/lzma support more platform and easier to install (without node-gyp/node-pre-gyp).

[codecov-commenter]

Codecov Report

Merging #864 (2e2d9db) into master (516e74a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   76.38%   76.41%   +0.03%     
==========================================
  Files          19       19              
  Lines         686      687       +1     
  Branches      131      131              
==========================================
+ Hits          524      525       +1     
  Misses        118      118              
  Partials       44       44              

Impacted Files	Coverage Δ
src/sysroot-fetcher.ts	84.84% <100.00%> (+0.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516e74a...2e2d9db. Read the comment docs.

[malept]

What platforms are you looking to support that lzma-native doesn't already support with a prebuilt module?

As much as I like Rust, I'm hesitant to add a dependency on a module that could possibly add a dependency on Rust itself.

Also FWIW the readme for lzma-native is a little out of date, it currently uses prebuildify / node-gyp-build to handle the native module building/bundling.

[Brooooooklyn]

What platforms are you looking to support that lzma-native doesn't already support with a prebuilt module?

Like linux-x64-musl/linux-aarch64-musl, windows-aarch64 and FreeBSD.

As much as I like Rust, I'm hesitant to add a dependency on a module that could possibly add a dependency on Rust itself.

Don't worry about it, you can even use this package in scratch Docker image like node:lts-alpine. It's been fully prebuilt.

[malept]

Like linux-x64-musl/linux-aarch64-musl, windows-aarch64 and FreeBSD.

As far as I can tell, lzma-native supports linux-arm64 and windows-arm64. I'm not particularly concerned about FreeBSD since Electron doesn't officially support it.

[Brooooooklyn]

lzma-native support linux-x64-gnu/linux-aarch64-gnu but not support linux-x64-musl/linux-aarch64-musl.

But I'm not sure if there were developers use electron on musl linux platform.

[malept]

lzma-native support linux-x64-gnu/linux-aarch64-gnu but not support linux-x64-musl/linux-aarch64-musl.

But I'm not sure if there were developers use electron on musl linux platform.

Electron itself requires glibc, so I doubt it.

[Brooooooklyn]

And this pull request will absolutely resolve issues like this: addaleax/lzma-native#102

[pbrit]

Like linux-x64-musl/linux-aarch64-musl, windows-aarch64 and FreeBSD.

As far as I can tell, lzma-native supports linux-arm64 and windows-arm64. I'm not particularly concerned about FreeBSD since Electron doesn't officially support it.

I believe the above is correct, however, it doesn't support darwin-arm64 which is getting more abundant with advent of Apple's M1 CPU.

This PR did fix my troubles with lzma-native (I'm proud Apple M1 user), and @napi-rs/lzma seems to be a quite neat approach.

@Brooooooklyn @malept Is there anything I can do to get it merged?

Merci @Brooooooklyn !

[malept]

Like linux-x64-musl/linux-aarch64-musl, windows-aarch64 and FreeBSD.

As far as I can tell, lzma-native supports linux-arm64 and windows-arm64. I'm not particularly concerned about FreeBSD since Electron doesn't officially support it.

I believe the above is correct, however, it doesn't support darwin-arm64 which is getting more abundant with advent of Apple's M1 CPU.

This PR did fix my troubles with lzma-native (I'm proud Apple M1 user), and @napi-rs/lzma seems to be a quite neat approach.

@Brooooooklyn @malept Is there anything I can do to get it merged?

Merci @Brooooooklyn !

I asked about darwin-arm64 support in addaleax/lzma-native#118. This PR is on hold until then.

[Brooooooklyn]

Any progress?

[Brooooooklyn]

@malept ready to merge again

[beorn]

This does solve a problem: Currently there doesn't seem to be any way to run electron-forge properly on M1 Macs:

• lzma-native is broken for M1 macs build: fix build on Apple Silicon addaleax/lzma-native#123
• arch=x86 is broken on M1 macs fix: Allow x64 arch on Mac Rosetta electron#32266

So there are no workarounds.

[electron-bot]

🎉 This issue has been resolved in version 3.2.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀