Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove support for the legacy notarization tool #1597

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Nov 5, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

BREAKING CHANGE: remove support for the tool option in osxNotarize, meaning notaryTool will always be used and users will no longer be able to provide tool: 'legacy' (see electron/notarize#141). This also removes the NotarizeLegacyOptions and OsxNotarizeOptions types because they're no longer necessary.

BREAKING CHANGE: remove support for the legacy notarization tool
BREAKING CHANGE: remove `NotarizeLegacyOptions` and `OsxNotarizeOptions` types
@erikian erikian requested a review from a team as a code owner November 5, 2023 15:15
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1597 (9778540) into main (e34d56c) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
- Coverage   95.66%   95.65%   -0.02%     
==========================================
  Files          15       15              
  Lines         785      783       -2     
==========================================
- Hits          751      749       -2     
  Misses         34       34              
Files Coverage Δ
src/mac.js 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@dsanders11 dsanders11 merged commit b21ea52 into main Nov 7, 2023
@dsanders11 dsanders11 deleted the chore/remove-legacy-notarization-tool branch November 7, 2023 01:43
Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants