Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove support for electron-prebuilt #1596

Merged
merged 6 commits into from
Nov 4, 2023

Conversation

erickzhao
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

BREAKING CHANGE: removes support for electron-prebuilt and electron-prebuilt-compile

@erickzhao erickzhao force-pushed the erick-prebuilt-delete-v2 branch from 261d401 to 7ecf02f Compare November 4, 2023 00:46
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #1596 (0edce8d) into main (54ee954) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   95.73%   95.66%   -0.07%     
==========================================
  Files          15       15              
  Lines         797      785      -12     
==========================================
- Hits          763      751      -12     
  Misses         34       34              
Files Coverage Δ
src/infer.js 100.00% <100.00%> (ø)
src/prune.js 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@erickzhao erickzhao marked this pull request as ready for review November 4, 2023 01:23
@erickzhao erickzhao requested a review from a team as a code owner November 4, 2023 01:23
@MarshallOfSound MarshallOfSound merged commit e34d56c into main Nov 4, 2023
@MarshallOfSound MarshallOfSound deleted the erick-prebuilt-delete-v2 branch November 4, 2023 01:36
Copy link

🎉 This PR is included in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants