Fix of the pglite-sync plugin for latest electric #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initial sync there is nigher the old
offset
or newlsn
+op_positon
on each message, we have to fallback to thestream.lastOffset
value which is the last offset of the final messages in the stream (retrieved from the http header). This replicates the behaviour of the plugin from before the changes to the sync protocol and ensures it will continue to work.However, we still need to make further changes, and the is likely to include changing the
commitGranularity
option. While this api is useful for incrementally inserting data during initial sync, it is not possible to actually resume from mid way in a snapshot.The further changes to this api will come as part of a larger refactor to the plugin.