Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve pre-existing index templates (#1900). #1912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve pre-existing index templates (#1900). #1912

wants to merge 1 commit into from
+29 −2

Conversation

fressi-elastic
Copy link
Contributor

Preserve pre-existing index templates (#1900).

When opening an EsMetricsStore, it creates the index template if any of following:

  • the index template doesn't exist
  • reporting/overwrite_existing_templates option is true

It will preserve existing template on all the other cases.

@fressi-elastic
Preserve pre-existing index templates (elastic#1900).
5a38d2e 
When opening an `EsMetricsStore`, it creates the index template if any of following:
 - the index template doesn't exist
 - `reporting/overwrite_existing_templates` option is `true`

It will preserve existing template on all the other cases.
@gareth-ellis gareth-ellis requested a review from a team February 5, 2025 14:02
@fressi-elastic fressi-elastic changed the title Issue/1900 Preserve pre-existing index templates (#1900). Feb 5, 2025
@gareth-ellis
Copy link
Member

Could we get an update to the docs done too, to explain this feature? Obviously we want to have it tested too before we merge

@gareth-ellis gareth-ellis added enhancement Improves the status quo highlight A substantial improvement that is worth mentioning separately in release notes labels Feb 6, 2025
@fressi-elastic
Copy link
Contributor Author

Could we get an update to the docs done too, to explain this feature? Obviously we want to have it tested too before we merge

I did tested and it works as expected in all cases except one: one the overwrite_existing_templates is false it looks like it act as it is true. I guess the code is parsing it as string instead of a boolean. I am investigating on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favilo favilo favilo approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo highlight A substantial improvement that is worth mentioning separately in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fressi-elastic @gareth-ellis @favilo