Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages regarding track syntax errors #1908

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

gareth-ellis
Copy link
Member

I've encountered a few cryptic error messages whilst tweeking a track.

Issues this solves:

  • If we fail to transform the templates completely due to a syntax error, we write that the full output is listed XXXX - it isnt, we never get round to writing it, so I am catching the TemplateSyntaxError and writing another error message. It would be nice if we can say what the error is, or at least where, but we can't yet. If I find a way I will add that to the PR / a new PR
  • If you don't include "operation", you get an Attribute error, but no information where in the track. Now we include a more helpful message that should help users see where the issue may be.

@gareth-ellis gareth-ellis requested a review from a team January 29, 2025 14:44
@gareth-ellis gareth-ellis added enhancement Improves the status quo :Usability Makes Rally easier to use labels Jan 29, 2025
Copy link

@dpifke-elastic dpifke-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

esrally/track/loader.py Outdated Show resolved Hide resolved
@gareth-ellis gareth-ellis merged commit c5b469d into master Jan 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants