Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard/Lens] Fix scroll jumping when editing from flyout #207429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Dashboard/Lens] Fix scroll jumping when editing from flyout #207429

wants to merge 2 commits into from
+10 −2

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Jan 21, 2025 •
edited
Loading

Summary

Fixes an issue that caused the body scroll to jump when clicking options in the Lens inline editor flyout.

Fixes #201544

This issue was created when we added the autoFocus option to the EuiSelectable for the dataview picker and the chart type picker.

This appears to be an issue with how eui is handling the autoFocus, see elastic/eui#8287.

In the meantime this is a workaround to prevent this scroll jumping while also keeping the auto focus behavior.

Zight.Recording.2025-01-21.at.01.14.11.PM.mp4

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@nickofthyme nickofthyme added Feature:Dashboard Dashboard related features release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Jan 21, 2025
@nickofthyme nickofthyme requested a review from a team as a code owner January 21, 2025 19:25
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jan 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nickofthyme nickofthyme requested a review from mbondyra January 21, 2025 19:25
@nickofthyme
Copy link
Contributor Author

@mbondyra Could you take a look at this and lmk what you think. You touched this code pretty recently. Thanks!

@nickofthyme nickofthyme added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Jan 21, 2025
@nickofthyme nickofthyme mentioned this pull request Jan 21, 2025
Open
@nickofthyme nickofthyme added the loe:small Small Level of Effort label Jan 22, 2025
mbondyra
mbondyra approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Feature:Dashboard Dashboard related features Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] [Inline editor] Clicking on chart switch makes the dashboard scroll to the top
4 participants
@nickofthyme @elasticmachine @mbondyra @kibanamachine