-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automatic Import] upgrade version in manifest #205942
Merged
haetamoudi
merged 4 commits into
elastic:main
from
haetamoudi:204643-automatic-import-update-manifest-version-constraint-and-spec-format-version
Jan 14, 2025
Merged
[Automatic Import] upgrade version in manifest #205942
haetamoudi
merged 4 commits into
elastic:main
from
haetamoudi:204643-automatic-import-update-manifest-version-constraint-and-spec-format-version
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haetamoudi
added
the
Team:Security-Scalability
Team label for Security Integrations Scalability Team
label
Jan 8, 2025
Pinging @elastic/security-scalability (Team:Security-Scalability) |
haetamoudi
added
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jan 8, 2025
haetamoudi
changed the title
upgrade version in manifest
[Automatic Import] upgrade version in manifest
Jan 8, 2025
kgeller
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ion-constraint-and-spec-format-version
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @haetamoudi |
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
enhancement
New value added to drive a business result
Feature:AutomaticImport
release_note:skip
Skip the PR/issue when compiling release notes
Team:Security-Scalability
Team label for Security Integrations Scalability Team
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump kibana constrain and support new major as well as format_version. #204643
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*
label is applied per the guidelinesTesting
Verify validation
Case 1 - Current settings:
fomat_version
3.1.4
andkibana_min_version
^8.13.0
)elastic-package build
Run into the following validation errors:
Error 1 & 2: Elastic-package validates that the datastream name contains more than 1 character
Error 3: - Elastic-package validates that potential secret field have the secret param
Case 2 - bumped versions:
fomat_version
3.3.1
andkibana_min_version
^8.13.0 || ^ 9.0.0
elastic-package build
There is no new validation errors introduced by 3.3.1 ✅
Verify compatibility
fomat_version
3.3.1
andkibana_min_version
^8.13.0 || ^ 9.0.0
8.15.0
.No issue ✅
Results of the testing
No new issue introduced after bumping the version of
format_version
&kibana_min_version
. However we current have some validation errors that can be fixed