Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automatic Import] upgrade version in manifest #205942

Conversation

haetamoudi
Copy link
Contributor

@haetamoudi haetamoudi commented Jan 8, 2025

Summary

Bump kibana constrain and support new major as well as format_version. #204643

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Testing

Verify validation

Case 1 - Current settings:

  1. Build an integration with current manifest settings (fomat_version 3.1.4 and kibana_min_version ^8.13.0)
  2. Download the newly created integration and run elastic-package build
    Run into the following validation errors:
Error: building package failed: invalid content found in built zip package: found 4 validation errors:
   1. item [a] is not allowed in folder [/Users/hanna/Downloads/testversion-1.0.0/build/packages/testversion-1.0.0.zip/data_stream]
   2. expecting to find folder matching pattern [^([a-z0-9]{2}|[a-z0-9][a-z0-9_]+[a-z0-9])$] in folder [/Users/hanna/Downloads/testversion-1.0.0/build/packages/testversion-1.0.0.zip/data_stream]
   3. file "/Users/hanna/Downloads/test3-1.0.0/build/packages/test3-1.0.0.zip/data_stream/as/manifest.yml" is invalid: field streams.4.vars.8: variable identified as possible secret, secret parameter required to be set to true or false

Error 1 & 2: Elastic-package validates that the datastream name contains more than 1 character
Error 3: - Elastic-package validates that potential secret field have the secret param

Case 2 - bumped versions:

  1. Build an integration with updated manifest settings (fomat_version 3.3.1 and kibana_min_version ^8.13.0 || ^ 9.0.0
  2. Download the newly created integration and run elastic-package build
    There is no new validation errors introduced by 3.3.1 ✅

Verify compatibility

  1. Build an integration with updated manifest settings (fomat_version 3.3.1 and kibana_min_version ^8.13.0 || ^ 9.0.0
  2. Install the newly created integration on stack 8.15.0.
    No issue ✅

Results of the testing

No new issue introduced after bumping the version of format_version & kibana_min_version. However we current have some validation errors that can be fixed

@haetamoudi haetamoudi requested a review from a team as a code owner January 8, 2025 17:16
@haetamoudi haetamoudi added the Team:Security-Scalability Team label for Security Integrations Scalability Team label Jan 8, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@haetamoudi haetamoudi added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Jan 8, 2025
@haetamoudi haetamoudi changed the title upgrade version in manifest [Automatic Import] upgrade version in manifest Jan 8, 2025
@haetamoudi haetamoudi self-assigned this Jan 8, 2025
@haetamoudi haetamoudi added the enhancement New value added to drive a business result label Jan 8, 2025
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haetamoudi haetamoudi enabled auto-merge (squash) January 14, 2025 11:58
@haetamoudi haetamoudi merged commit eae7b7d into elastic:main Jan 14, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / CasesWebhookActionConnectorFields renders Validation validates correctly "webhookCreateUrlText"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 1.1MB 1.1MB +97.0B

History

cc @haetamoudi

viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:AutomaticImport release_note:skip Skip the PR/issue when compiling release notes Team:Security-Scalability Team label for Security Integrations Scalability Team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Automatic Import] Update manifest version constraint and spec format version
4 participants