Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced (#205604) #205938

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[8.x] fix: [Security:Cases] Sync alert status with case status toggle button under case settings on create case page is incorrectly announced (#205604) #205938

merged 1 commit into from
Jan 8, 2025

Conversation

kibanamachine
Copy link
Contributor

@alexwizp
fix: [Security:Cases] Sync alert status with case status toggle butto…
afda69b 
…n under case settings on create case page is incorrectly announced (elastic#205604)

Closes: elastic#205544

## Description
When user tabs over sync alert status with case status toggle button
under case settings on create case page, screenreader announces On, On
switch without giving any context.

## Preconditions
Security solution -> on cases page -> create case

## Changes made:
1. added context for **EuiSwitch** by passing `aria-labelledby`
attribute

## Screen

![image](https://github.com/user-attachments/assets/94fb0413-d0c6-4a1c-9071-a6458e2cd379)

(cherry picked from commit efe44b2)
@kibanamachine kibanamachine enabled auto-merge (squash) January 8, 2025 17:03
@kibanamachine kibanamachine mentioned this pull request Jan 8, 2025
Merged
@kibanamachine kibanamachine merged commit e1b0491 into elastic:8.x Jan 8, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / Tags when list is long renders a truncated list of tags with full list displayed in tooltip on hover
  • [job] [logs] Jest Tests #3 / Test packages All test packages should be valid (node scripts/verify_test_packages)
  • [job] [logs] Jest Tests #3 / useActionStatus should post cancel and invoke callback on cancel upgrade
  • [job] [logs] Jest Tests #3 / useActionStatus should post cancel and invoke callback on cancel upgrade - plural
  • [job] [logs] Jest Tests #3 / useActionStatus should report error on cancel upgrade failure

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 106.9KB 107.0KB +58.0B

cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@alexwizp alexwizp

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @alexwizp