Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix creating a policy in a different space than the current #205925

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 8, 2025

Summary

Resolve #203527

Fix creating a policy in a different space than the current one.

Tests

I added automated API integration test to cover that scenario.

You can manually test this by enabling space awarenes (feature flag + API call)

with 2 space (default and test)

Create a policy in test from the default space, verify that policy is only visible in the test space.

In default space:
Screenshot 2025-01-08 at 11 12 09 AM

In test space:
Screenshot 2025-01-08 at 11 12 38 AM

@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 8, 2025
@nchaulet nchaulet self-assigned this Jan 8, 2025
@nchaulet nchaulet requested a review from a team as a code owner January 8, 2025 16:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Jan 8, 2025
@nchaulet
Copy link
Member Author

nchaulet commented Jan 8, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 8, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests #4 / Add Integration - Automatic Import should create an integration
  • [job] [logs] Fleet Cypress Tests #4 / Add Integration - Automatic Import should create an integration
  • [job] [logs] Fleet Cypress Tests #2 / When the user has All permissions for Integrations and All permissions for actions Create Assistant is not accessible but upload is accessible
  • [job] [logs] Fleet Cypress Tests #2 / When the user has All permissions for Integrations and All permissions for actions Create Assistant is not accessible but upload is accessible

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +3.0B

History

cc @nchaulet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: User is unable to create agent policy from Default space to Space1.
3 participants