Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [ECO] Use new Entity v2 endpoints in Inventory (#203452) #205911

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from
Open

[8.x] [ECO] Use new Entity v2 endpoints in Inventory (#203452) #205911

wants to merge 1 commit into from

Conversation

rmyz
Copy link
Contributor

@rmyz rmyz commented Jan 8, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@rmyz
[ECO] Use new Entity v2 endpoints in Inventory (elastic#203452)
a9b3c18 
## Summary

Closes elastic#202295
Closes elastic#202296

This PR adapts Inventory to use the new Entity v2 endpoints.

## Testing
- Use any synthtrace scenario that loads service/hosts/containers data
- Navigate and make sure everything works as expected (navigation to
Discovery/Infra/Services pages, interacting with the table, searching
for some specific entity, interacting with the type filter)
- To check the alerts work, it's easier to connect to a remote cluster.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Jenny <[email protected]>
(cherry picked from commit eb919c9)

# Conflicts:
#	x-pack/solutions/observability/plugins/inventory/server/routes/entities/get_group_by_terms_agg.test.ts
#	x-pack/solutions/observability/plugins/inventory/server/routes/entities/get_group_by_terms_agg.ts
#	x-pack/solutions/observability/plugins/inventory/server/routes/entities/get_latest_entities_alerts.ts
#	x-pack/solutions/observability/plugins/inventory/server/routes/entities/route.ts
@rmyz rmyz added the backport label Jan 8, 2025
@rmyz rmyz requested a review from kibanamachine as a code owner January 8, 2025 14:46
@rmyz rmyz enabled auto-merge (squash) January 8, 2025 14:46
@rmyz rmyz mentioned this pull request Jan 8, 2025
Merged
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 238 237 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
entityManager 43 45 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 231.7KB 231.5KB -249.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
inventory 4 3 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
entityManager 8.5KB 8.5KB -5.0B
observabilityShared 93.9KB 94.3KB +442.0B
total +437.0B
Unknown metric groups

API count

id before after diff
entityManager 43 45 +2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

@Bluefinger Bluefinger Bluefinger approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmyz @elasticmachine @Bluefinger @jennypavlova